Manchester | 26-ITP-May | Abdu Hassen | Sprint 2 | wireframe #1366
Open
Abduhasen wants to merge 1 commit into
Open
Manchester | 26-ITP-May | Abdu Hassen | Sprint 2 | wireframe #1366Abduhasen wants to merge 1 commit into
Abduhasen wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Abduhasen
added
📅 Sprint 2
cjyuan
reviewed
May 30, 2026
Contributor
There was a problem hiding this comment.
Code is error free and well formatted. Page layout is strong. Well done.
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
-
The unordered list in the "Changelist" section of the PR description is not correctly formatted in Markdown. Can you fix it?
Contributor
There was a problem hiding this comment.
There are two main selectors in this file. Consider merging the properties from both selectors into a single main rule to make them easier to find and maintain.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to the article
Learners, PR Template
Self checklist
Changelist
-Based on the wireframe that was provided i made web page that explain git branch,wireframe and read file
-Added a link that can proved more information
-Added image that can explain the article
Questions
N/A